]> git.baikalelectronics.ru Git - kernel.git/commit
Revert unintentional "volatile" changes in ipc/msg.c
authorLinus Torvalds <torvalds@g5.osdl.org>
Sat, 4 Nov 2006 17:55:00 +0000 (09:55 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 4 Nov 2006 17:55:00 +0000 (09:55 -0800)
commit749e026c3739cb101e09a8f11f6b23761997a8f3
tree81d506d9559c13c090cc853d13f48fcf982795df
parent74c09d960b9ff494b003969ffc2229aa2c89060a
Revert unintentional "volatile" changes in ipc/msg.c

Commit 379473d7f7ae5952e1cf7be1ea1ef4375e05b434 ("[PATCH] ipc/msg.c:
clean up coding style") breaks fakeroot on Alpha (variously hangs or
oopses), according to a report by Falk Hueffner.

The fact that the code seems to rely on compiler access ordering through
the use of "volatile" is a pretty certain sign that the code has locking
problems, and we should fix those properly and then remove the whole
"volatile" entirely.

But in the meantime, the movement of "volatile" was unintentional, and
should be reverted.

Cc: Falk Hueffner <falk@debian.org>
Cc: Andrew Morton <akpm@osdl.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
ipc/msg.c