]> git.baikalelectronics.ru Git - kernel.git/commit
bpf, lsm: Fix the file_mprotect LSM test.
authorKP Singh <kpsingh@google.com>
Thu, 2 Apr 2020 20:07:51 +0000 (22:07 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 3 Apr 2020 02:42:52 +0000 (19:42 -0700)
commit7442910e2d3c7e3ceff0ebb68067c39cae06139a
tree79a2b386c0cc2f1dbbcd1e186f5b38ecb6947447
parent1174ed7f78063bb874305586828ed88ccfa509bf
bpf, lsm: Fix the file_mprotect LSM test.

The test was previously using an mprotect on the heap memory allocated
using malloc and was expecting the allocation to be always using
sbrk(2). This is, however, not always true and in certain conditions
malloc may end up using anonymous mmaps for heap alloctions. This means
that the following condition that is used in the "lsm/file_mprotect"
program is not sufficent to detect all mprotect calls done on heap
memory:

is_heap = (vma->vm_start >= vma->vm_mm->start_brk &&
   vma->vm_end <= vma->vm_mm->brk);

The test is updated to use an mprotect on memory allocated on the stack.
While this would result in the splitting of the vma, this happens only
after the security_file_mprotect hook. So, the condition used in the BPF
program holds true.

Fixes: 8b0df9589b94 ("bpf: lsm: Add selftests for BPF_PROG_TYPE_LSM")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: KP Singh <kpsingh@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20200402200751.26372-1-kpsingh@chromium.org
tools/testing/selftests/bpf/prog_tests/test_lsm.c
tools/testing/selftests/bpf/progs/lsm.c