]> git.baikalelectronics.ru Git - kernel.git/commit
ixgbe: fix namespace issues when FCoE/DCB is not enabled
authorJeff Kirsher <jeffrey.t.kirsher@intel.com>
Sat, 18 Feb 2012 07:08:14 +0000 (07:08 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 19 Mar 2012 20:59:11 +0000 (13:59 -0700)
commit738f443806056a469980f5d45b916b6ff987fbb7
tree4213b4f6c0014783cc89d340a04611ed7cfa4e15
parent34a7b8442996cfc6162106c589efb244ae35b25c
ixgbe: fix namespace issues when FCoE/DCB is not enabled

Resolve namespace issues when FCoE or DCB is not enabled.
The issue is with certain configurations we end up with namespace
problems. A simple example:

ixgbe_main.c
 - defines func A()
 - uses func A()

ixgbe_fcoe.c
 - uses func A()

ixgbe.h
 - has prototype for func A()

For default (FCoE included) all is good.  But when it isn't the namespace
checker complains about how func A() could be static.

To resolve this, created a ixgbe_lib file to contain functions used
by DCB/FCoE and their helper functions so that they are always in
namespace whether or not DCB/FCoE is enabled.

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
drivers/net/ethernet/intel/ixgbe/Makefile
drivers/net/ethernet/intel/ixgbe/ixgbe.h
drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c [new file with mode: 0644]
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c