]> git.baikalelectronics.ru Git - kernel.git/commit
media: imx258: Limit the max analogue gain to 480
authorUmang Jain <umang.jain@ideasonboard.com>
Fri, 23 Jul 2021 11:22:33 +0000 (13:22 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 4 Aug 2021 12:43:51 +0000 (14:43 +0200)
commit72eee5b5a69af3e85c72a6810a1171ae71e90501
tree2096c5f113ce37639431c045a069a6705bcb8869
parent835691e2ef14a2a9dce661bf440d1980c0e33de1
media: imx258: Limit the max analogue gain to 480

The range for analog gain mentioned in the datasheet is [0, 480].
The real gain formula mentioned in the datasheet is:

Gain = 512 / (512 – X)

Hence, values larger than 511 clearly makes no sense. The gain
register field is also documented to be of 9-bits in the datasheet.

Certainly, it is enough to infer that, the kernel driver currently
advertises an arbitrary analog gain max. Fix it by rectifying the
value as per the data sheet i.e. 480.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/imx258.c