]> git.baikalelectronics.ru Git - kernel.git/commit
mfd: twl6040: Fix child-node lookup
authorJohan Hovold <johan@kernel.org>
Sat, 11 Nov 2017 15:38:44 +0000 (16:38 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 29 Nov 2017 16:29:36 +0000 (16:29 +0000)
commit72e31d1a7aee4c75cc2e833afc7c30d134fde2e9
tree697601b0a1b1d5da36e8d7f9a57f30e3ced70830
parenta9c78fc199f948bbb939a79ce24b30f979f73a5f
mfd: twl6040: Fix child-node lookup

Fix child-node lookup during probe, which ended up searching the whole
device tree depth-first starting at the parent rather than just matching
on its children.

To make things worse, the parent node was prematurely freed, while the
child node was leaked.

Note that the CONFIG_OF compile guard can be removed as
of_get_child_by_name() provides a !CONFIG_OF implementation which always
fails.

Cc: stable <stable@vger.kernel.org> # 3.5
Fixes: a7c1430ff3ad ("mfd: Add support for Device Tree to twl6040")
Fixes: 8f1ada07e3c5 ("mfd: Fix twl6040 build failure")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/twl6040.c