]> git.baikalelectronics.ru Git - kernel.git/commit
caif_virtio: fix race between virtio_device_ready() and ndo_open()
authorJason Wang <jasowang@redhat.com>
Mon, 20 Jun 2022 05:11:14 +0000 (13:11 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 7 Jul 2022 15:36:49 +0000 (17:36 +0200)
commit72c7d3f66fcdb4ff2eebf8f33494a4daa920ebf5
tree94f34a00a75652c20223ca12641c57bfa15f4ce1
parentd6845c850555b548b98eaa6ddd0c35a08b91078e
caif_virtio: fix race between virtio_device_ready() and ndo_open()

commit bf14c8d153b2a633a7256ef53787ba1e486683b8 upstream.

We currently depend on probe() calling virtio_device_ready() -
which happens after netdev
registration. Since ndo_open() can be called immediately
after register_netdev, this means there exists a race between
ndo_open() and virtio_device_ready(): the driver may start to use the
device (e.g. TX) before DRIVER_OK which violates the spec.

Fix this by switching to use register_netdevice() and protect the
virtio_device_ready() with rtnl_lock() to make sure ndo_open() can
only be called after virtio_device_ready().

Fixes: 0becb56749060 ("caif_virtio: Introduce caif over virtio")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20220620051115.3142-3-jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/caif/caif_virtio.c