]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx4: Fix UBSAN warning of signed integer overflow
authorAya Levin <ayal@mellanox.com>
Thu, 15 Nov 2018 16:05:15 +0000 (18:05 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 Nov 2018 00:09:31 +0000 (16:09 -0800)
commit721c9caba2fc53333ea978e768abce9a43a13626
tree824d23c2ec65e42a6656221b6f749880455cbaca
parentedf3d40c46c2d2a9432323af9e885fd8e7dc357b
net/mlx4: Fix UBSAN warning of signed integer overflow

UBSAN: Undefined behavior in
drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:626:29
signed integer overflow: 1802201963 + 1802201963 cannot be represented
in type 'int'

The union of res_reserved and res_port_rsvd[MLX4_MAX_PORTS] monitors
granting of reserved resources. The grant operation is calculated and
protected, thus both members of the union cannot be negative.  Changed
type of res_reserved and of res_port_rsvd[MLX4_MAX_PORTS] from signed
int to unsigned int, allowing large value.

Fixes: 2928f2fefacc ("mlx4: Structures and init/teardown for VF resource quotas")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/mlx4.h