]> git.baikalelectronics.ru Git - kernel.git/commit
net: sit: unregister_netdevice on newlink's error path
authorJakub Kicinski <kuba@kernel.org>
Thu, 14 Jan 2021 01:29:47 +0000 (17:29 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 14 Jan 2021 18:26:46 +0000 (10:26 -0800)
commit72060a7cc6c81d1df2d96549b4a988438f65271d
tree9f6f1441fd7d9f964c6019f16fd80a292c8bd035
parent98923e6c12a7174b7e725eaa921565e9756fc524
net: sit: unregister_netdevice on newlink's error path

We need to unregister the netdevice if config failed.
.ndo_uninit takes care of most of the heavy lifting.

This was uncovered by recent commit b28790419bb3 ("net: make
free_netdev() more lenient with unregistering devices").
Previously the partially-initialized device would be left
in the system.

Reported-and-tested-by: syzbot+2393580080a2da190f04@syzkaller.appspotmail.com
Fixes: 7106a7c74c10 ("sit: allow to configure 6rd tunnels via netlink")
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Link: https://lore.kernel.org/r/20210114012947.2515313-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/sit.c