]> git.baikalelectronics.ru Git - kernel.git/commit
rtc: msm6242: Initialize drvdata before registering device
authorJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 00:28:36 +0000 (17:28 -0700)
committerJohn Stultz <john.stultz@linaro.org>
Sat, 7 May 2011 01:02:03 +0000 (18:02 -0700)
commit71b31d693d10bb56f7856f40d5abbb71fcf73c4e
tree2e684b034430428a0e3664b58ca9302a34c2b66c
parent40a301b047808e043885622842e2c632a79bfbaf
rtc: msm6242: Initialize drvdata before registering device

Commit 7a6b0e5dea5 ("RTC: Initialize kernel state from RTC") uncovered
an issue in a number of RTC drivers, where the drivers call
rtc_device_register before initializing the device or platform drvdata.

This frequently results in null pointer dereferences when the
rtc_device_register immediately makes use of the rtc device, calling
rtc_read_alarm.

The solution is to ensure the drvdata is initialized prior to registering
the rtc device.

CC: Wolfram Sang <w.sang@pengutronix.de>
CC: Alessandro Zummo <a.zummo@towertech.it>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: rtc-linux@googlegroups.com
Signed-off-by: John Stultz <john.stultz@linaro.org>
drivers/rtc/rtc-msm6242.c