]> git.baikalelectronics.ru Git - kernel.git/commit
batman-adv: Fix bat_ogm_iv best gw refcnt after netlink dump
authorSven Eckelmann <sven@narfation.org>
Sat, 2 Jun 2018 15:26:34 +0000 (17:26 +0200)
committerSimon Wunderlich <sw@simonwunderlich.de>
Sat, 23 Jun 2018 08:29:33 +0000 (10:29 +0200)
commit71566a39ff76d7eadaa300b04d80b3e1d121e02c
tree79eb477220cbcfa9d33ad7b071373bbed8a72fab
parent0d5624e606504772b89d3c3d6b1be740ef176c61
batman-adv: Fix bat_ogm_iv best gw refcnt after netlink dump

A reference for the best gateway is taken when the list of gateways in the
mesh is sent via netlink. This is necessary to check whether the currently
dumped entry is the currently selected gateway or not. This information is
then transferred as flag BATADV_ATTR_FLAG_BEST.

After the comparison of the current entry is done,
batadv_iv_gw_dump_entry() has to decrease the reference counter again.
Otherwise the reference will be held and thus prevents a proper shutdown of
the batman-adv interfaces (and some of the interfaces enslaved in it).

Fixes: 27686bdbbf2e ("batman-adv: add B.A.T.M.A.N. IV bat_gw_dump implementations")
Reported-by: Andreas Ziegler <dev@andreas-ziegler.de>
Tested-by: Andreas Ziegler <dev@andreas-ziegler.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/bat_iv_ogm.c