]> git.baikalelectronics.ru Git - kernel.git/commit
can: j1939: transport: j1939_session_skb_drop_old(): spin_unlock_irqrestore() before...
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 27 Oct 2022 09:12:37 +0000 (17:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Nov 2022 14:56:52 +0000 (23:56 +0900)
commit714699917c41507cffe156d5f670073026e79041
tree8b9c5f3450f858d308a6c4d26965bf6c0785d190
parent707cbc7c97fb594b517c5464f9f2d2c47bd0ab49
can: j1939: transport: j1939_session_skb_drop_old(): spin_unlock_irqrestore() before kfree_skb()

commit a7cc53ac46d168ef5a70c79b1a13999bd7e504eb upstream.

It is not allowed to call kfree_skb() from hardware interrupt context
or with interrupts being disabled. The skb is unlinked from the queue,
so it can be freed after spin_unlock_irqrestore().

Fixes: 877b9bba3266 ("can: add support of SAE J1939 protocol")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://lore.kernel.org/all/20221027091237.2290111-1-yangyingliang@huawei.com
Cc: stable@vger.kernel.org
[mkl: adjust subject]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/can/j1939/transport.c