]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: snmp: add statistics for tcp small queue check"
authorEric Dumazet <edumazet@google.com>
Wed, 1 Dec 2021 03:32:46 +0000 (19:32 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 2 Dec 2021 03:06:09 +0000 (19:06 -0800)
commit70d4bdd2a62e3831c2099a3093f3ce2a70f93495
treeee9c848444134a92a77dfab024e3c7b6c14183e2
parent113330adc97e4e20cd8f32a0e07c1c1d904c4dfd
Revert "net: snmp: add statistics for tcp small queue check"

This reverts commit 91f7f2deb22682bfcdc959fe7ef6c4d683e2927f.

The new SNMP variable (TCPSmallQueueFailure) can be incremented
for good reasons, even on a 100Gbit single TCP_STREAM flow.

If we really wanted to ease driver debugging [1], this would
require something more sophisticated.

[1] Usually, if a driver is delaying TX completions too much,
this can lead to stalls in TCP output. Various work arounds
have been used in the past, like skb_orphan() in ndo_start_xmit().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Menglong Dong <imagedong@tencent.com>
Link: https://lore.kernel.org/r/20211201033246.2826224-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/uapi/linux/snmp.h
net/ipv4/proc.c
net/ipv4/tcp_output.c