]> git.baikalelectronics.ru Git - kernel.git/commit
clk: mediatek: pll: Implement error handling in register API
authorChen-Yu Tsai <wenst@chromium.org>
Tue, 8 Feb 2022 12:40:28 +0000 (20:40 +0800)
committerStephen Boyd <sboyd@kernel.org>
Thu, 17 Feb 2022 20:12:24 +0000 (12:12 -0800)
commit70ca76a210cf8d7afc8886860c8b5d0f73a83f76
treebde681620ef9bb28bd56bd8241c1539d71de341e
parent0c6cc20090d98fc3710f7c09aee5467e632b2493
clk: mediatek: pll: Implement error handling in register API

The pll clk type registration function does not stop or return errors
if any clk failed to be registered, nor does it implement an error
handling path. This may result in a partially working device if any
step failed.

Make the register function return proper error codes, and bail out if
errors occur. Proper cleanup, i.e. unregister any clks that were
successfully registered, and unmap the I/O space, is done in the new
error path.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220208124034.414635-26-wenst@chromium.org
Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/mediatek/clk-pll.c
drivers/clk/mediatek/clk-pll.h