]> git.baikalelectronics.ru Git - kernel.git/commit
random32: Fix implicit truncation warning in prandom_seed_state()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 25 May 2021 12:20:12 +0000 (13:20 +0100)
committerPetr Mladek <pmladek@suse.com>
Thu, 27 May 2021 13:38:17 +0000 (15:38 +0200)
commit708b1cfb95ccff3cc9c10e9cd6f7f8d0feb03378
treef801624d48b5121671faa5850da28b92591c4f8c
parent0b50f72b44cfd8b04338f36505d4d38bf109b9ba
random32: Fix implicit truncation warning in prandom_seed_state()

sparse generates the following warning:

 include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits from
 constant value

This is because the 64-bit seed value is manipulated and then placed in a
u32, causing an implicit cast and truncation. A forced cast to u32 doesn't
prevent this warning, which is reasonable because a typecast doesn't prove
that truncation was expected.

Logical-AND the value with 0xffffffff to make explicit that truncation to
32-bit is intended.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210525122012.6336-3-rf@opensource.cirrus.com
include/linux/prandom.h