]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "xen-netback: Check for hotplug-status existence before watching"
authorMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Tue, 22 Feb 2022 00:18:17 +0000 (01:18 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 24 Feb 2022 16:58:37 +0000 (08:58 -0800)
commit70321a36d6d2131ccbe10a75fe08ad5f40a46add
tree43b4ed99bf310b7c819102a6a3b50f09d0d03942
parent760c50d0780df36dbf52e5b9024f04f99373daf9
Revert "xen-netback: Check for hotplug-status existence before watching"

This reverts commit 8bfe1af096cbe955fbd4dcd0d47b051bc8c515a7.

The reasoning in the commit was wrong - the code expected to setup the
watch even if 'hotplug-status' didn't exist. In fact, it relied on the
watch being fired the first time - to check if maybe 'hotplug-status' is
already set to 'connected'. Not registering a watch for non-existing
path (which is the case if hotplug script hasn't been executed yet),
made the backend not waiting for the hotplug script to execute. This in
turns, made the netfront think the interface is fully operational, while
in fact it was not (the vif interface on xen-netback side might not be
configured yet).

This was a workaround for 'hotplug-status' erroneously being removed.
But since that is reverted now, the workaround is not necessary either.

More discussion at
https://lore.kernel.org/xen-devel/afedd7cb-a291-e773-8b0d-4db9b291fa98@ipxe.org/T/#u

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: Michael Brown <mbrown@fensystems.co.uk>
Link: https://lore.kernel.org/r/20220222001817.2264967-2-marmarek@invisiblethingslab.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/xen-netback/xenbus.c