]> git.baikalelectronics.ru Git - kernel.git/commit
mlxsw: spectrum: Fix memory leak at skb reallocation
authorArkadi Sharshevsky <arkadis@mellanox.com>
Thu, 12 Jan 2017 08:10:37 +0000 (09:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jan 2017 14:25:55 +0000 (09:25 -0500)
commit702e476bd0d4e60d4b0f61ebf6e8aa61d4883d2c
tree050d254d2269e55c9cd2744cda8852bb2c56de72
parentdc15f98bec8966d9871e5619f17afae0d0ba73e2
mlxsw: spectrum: Fix memory leak at skb reallocation

During transmission the skb is checked for headroom in order to
add vendor specific header. In case the skb needs to be re-allocated,
skb_realloc_headroom() is called to make a private copy of the original,
but doesn't release it. Current code assumes that the original skb is
released during reallocation and only releases it at the error path
which causes a memory leak.

Fix this by adding the original skb release to the main path.

Fixes: 91747a7223b2 ("mlxsw: spectrum: Add initial support for Spectrum ASIC")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c