]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "serial: max310x: pass return value of spi_register_driver"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:37 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:30:18 +0000 (17:30 +0200)
commit7009a94d6fa10d2e417be33518512107ae7ac8b7
treecca4477c1854ca20c55dfb0a93e64468a9a4c312
parent76d8ca451036043304bfd46e2fdd13c2b3a8de19
Revert "serial: max310x: pass return value of spi_register_driver"

This reverts commit d0656eb20853f52c1569635e8282773aa71a3339.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

This change did not properly unwind from the error condition, so it was
not correct.

Cc: Kangjie Lu <kjlu@umn.edu>
Acked-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-11-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/max310x.c