]> git.baikalelectronics.ru Git - kernel.git/commit
net: skb: introduce and use a single page frag cache
authorPaolo Abeni <pabeni@redhat.com>
Wed, 28 Sep 2022 08:43:09 +0000 (10:43 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 30 Sep 2022 01:48:15 +0000 (18:48 -0700)
commit6fb5bfc1bc06e965e155e8059ed830ecf293eceb
treed946ed8bfe8065c876dd40d230d7ab11155bd90d
parent283a96d38b355c8cf88b9fad90c6748334c0c334
net: skb: introduce and use a single page frag cache

After commit 0a95c7028409 ("net: avoid 32 x truesize under-estimation
for tiny skbs") we are observing 10-20% regressions in performance
tests with small packets. The perf trace points to high pressure on
the slab allocator.

This change tries to improve the allocation schema for small packets
using an idea originally suggested by Eric: a new per CPU page frag is
introduced and used in __napi_alloc_skb to cope with small allocation
requests.

To ensure that the above does not lead to excessive truesize
underestimation, the frag size for small allocation is inflated to 1K
and all the above is restricted to build with 4K page size.

Note that we need to update accordingly the run-time check introduced
with commit 092135d3d0ca ("net: add napi_get_frags_check() helper").

Alex suggested a smart page refcount schema to reduce the number
of atomic operations and deal properly with pfmemalloc pages.

Under small packet UDP flood, I measure a 15% peak tput increases.

Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Suggested-by: Alexander H Duyck <alexanderduyck@fb.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Link: https://lore.kernel.org/r/6b6f65957c59f86a353fc09a5127e83a32ab5999.1664350652.git.pabeni@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netdevice.h
net/core/dev.c
net/core/skbuff.c