]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/pmu: Don't grab wakeref when enabling events
authorTvrtko Ursulin <tvrtko.ursulin@intel.com>
Mon, 14 Dec 2020 09:43:47 +0000 (09:43 +0000)
committerTvrtko Ursulin <tvrtko.ursulin@intel.com>
Mon, 14 Dec 2020 12:55:43 +0000 (12:55 +0000)
commit6fae087b30a788dd80b94f959123d6909248098a
tree9a33eb841fb7d6c0b8c21b73ebbe5f1188c7fa39
parent1fbe77cd8474ca97b3d7e0e6f5a3064149f29101
drm/i915/pmu: Don't grab wakeref when enabling events

Chris found a CI report which points out calling intel_runtime_pm_get from
inside i915_pmu_enable hook is not allowed since it can be invoked from
hard irq context. This is something we knew but forgot, so lets fix it
once again.

We do this by syncing the internal book keeping with hardware rc6 counter
on driver load.

v2:
 * Always sync on parking and fully sync on init.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: a1ba95c9c70e ("drm/i915/pmu: Correct the rc6 offset upon enabling")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201214094349.3563876-1-tvrtko.ursulin@linux.intel.com
drivers/gpu/drm/i915/i915_pmu.c