]> git.baikalelectronics.ru Git - kernel.git/commit
usb: gadget: u_audio: fix race condition on endpoint stop
authorJerome Brunet <jbrunet@baylibre.com>
Fri, 27 Aug 2021 09:29:27 +0000 (11:29 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Sep 2021 08:08:14 +0000 (10:08 +0200)
commit6f9a1e26d5e04de1d6754e6388175c1c6d4046b8
tree171de2b57c097d0ff65b6801733370fd0082853f
parent4f425a4409a633a11ec3dab7bb6311066e85606b
usb: gadget: u_audio: fix race condition on endpoint stop

[ Upstream commit 068fdad20454f815e61e6f6eb9f051a8b3120e88 ]

If the endpoint completion callback is call right after the ep_enabled flag
is cleared and before usb_ep_dequeue() is call, we could do a double free
on the request and the associated buffer.

Fix this by clearing ep_enabled after all the endpoint requests have been
dequeued.

Fixes: 72779d7f8992 ("usb: gadget: u_audio: Free requests only after callback")
Cc: stable <stable@vger.kernel.org>
Reported-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Link: https://lore.kernel.org/r/20210827092927.366482-1-jbrunet@baylibre.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/u_audio.c