]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vc4: crtc: Skip the TXP
authorMaxime Ripard <maxime@cerno.tech>
Fri, 7 May 2021 15:05:05 +0000 (17:05 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 24 May 2021 12:41:34 +0000 (14:41 +0200)
commit6f83da9e79f0e1f9d45b7b08b842005c8a4f0c27
treefbee0088452d93ff815d9e3b1ce8ab2683db2068
parente1dbe83056c5753e62170cf448a8a64f5e62aee0
drm/vc4: crtc: Skip the TXP

The vc4_set_crtc_possible_masks is meant to run over all the encoders
and then set their possible_crtcs mask to their associated pixelvalve.

However, since the commit db980865a026 ("drm/vc4: txp: Turn the TXP into
a CRTC of its own"), the TXP has been turned to a CRTC and encoder of
its own, and while it does indeed register an encoder, it no longer has
an associated pixelvalve. The code will thus run over the TXP encoder
and set a bogus possible_crtcs mask, overriding the one set in the TXP
bind function.

In order to fix this, let's skip any virtual encoder.

Cc: <stable@vger.kernel.org> # v5.9+
Fixes: db980865a026 ("drm/vc4: txp: Turn the TXP into a CRTC of its own")
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210507150515.257424-3-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_crtc.c