]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: rsnd: fixup MIX kctrl registration
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 1 Feb 2019 07:49:30 +0000 (16:49 +0900)
committerMark Brown <broonie@kernel.org>
Sat, 2 Feb 2019 15:41:29 +0000 (15:41 +0000)
commit6f25b6616856407bc2bd2eb09e775af1aca57367
tree7af6a24dd84a90576bdadb24ec7feae06615f964
parent4fa549d38cd6693f038932ef35b02b43e6015e06
ASoC: rsnd: fixup MIX kctrl registration

Renesas sound device has many IPs and many situations.
If platform/board uses MIXer, situation will be more complex.
To avoid duplicate DVC kctrl registration when MIXer was used,
it had original flags.
But it was issue when sound card was re-binded, because
no one can't cleanup this flags then.

To solve this issue, commit fec6c4bcc5f330c44 ("ASoC: rsnd: tidyup
registering method for rsnd_kctrl_new()") checks registered
card->controls, because if card was re-binded, these were cleanuped
automatically. This patch could solve re-binding issue.
But, it start to avoid MIX kctrl.

To solve these issues, we need below.
To avoid card re-binding issue: check registered card->controls
To avoid duplicate DVC registration: check registered rsnd_kctrl_cfg
To allow multiple MIX registration: check registered rsnd_kctrl_cfg
This patch do it.

Fixes: fec6c4bcc5f330c44 ("ASoC: rsnd: tidyup registering method for rsnd_kctrl_new()")
Reported-by: Jiada Wang <jiada_wang@mentor.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-By: Jiada Wang <jiada_wang@mentor.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c