]> git.baikalelectronics.ru Git - kernel.git/commit
bna: Avoid reading past end of buffer
authorKees Cook <keescook@chromium.org>
Fri, 5 May 2017 22:25:32 +0000 (15:25 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 8 May 2017 18:41:41 +0000 (14:41 -0400)
commit6ecd03e571daad30d8292dc03cc87448f9454330
treec98e366cdbadd084541b6722371b68af37a9d4f6
parent842a5075e251a5c79bf8c4b8d9818e71e410907d
bna: Avoid reading past end of buffer

Using memcpy() from a string that is shorter than the length copied means
the destination buffer is being filled with arbitrary data from the kernel
rodata segment. Instead, use strncpy() which will fill the trailing bytes
with zeros.

This was found with the future CONFIG_FORTIFY_SOURCE feature.

Cc: Daniel Micay <danielmicay@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/brocade/bna/bfa_ioc.c