]> git.baikalelectronics.ru Git - kernel.git/commit
membarrier: Fix RCU locking bug caused by faulty merge
authorPeter Zijlstra <peterz@infradead.org>
Tue, 1 Oct 2019 08:50:33 +0000 (10:50 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 1 Oct 2019 19:27:50 +0000 (21:27 +0200)
commit6eb183e313f99f14d8cc86cb79b963a490ac6d7d
treecbfbc86f18448d0e9cfd044bb2f0d6bf4389b423
parentf5c4776cd5b591eea4e9be9f421e34f61b98ebb2
membarrier: Fix RCU locking bug caused by faulty merge

The following commit:

  951974a40dd9 ("sched/membarrier: Fix p->mm->membarrier_state racy load")

got fat fingered by me when merging it with other patches. It meant to move
the RCU section out of the for loop but ended up doing it partially, leaving
a superfluous rcu_read_lock() inside, causing havok.

Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Kirill Tkhai <tkhai@yandex.ru>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Paul E. McKenney <paulmck@linux.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-tip-commits@vger.kernel.org
Fixes: 951974a40dd9 ("sched/membarrier: Fix p->mm->membarrier_state racy load")
Link: https://lkml.kernel.org/r/20191001085033.GP4519@hirez.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/membarrier.c