]> git.baikalelectronics.ru Git - kernel.git/commit
mm/gup: fix comments to pin_user_pages_*()
authorYury Norov <yury.norov@gmail.com>
Tue, 10 May 2022 01:20:47 +0000 (18:20 -0700)
committerakpm <akpm@linux-foundation.org>
Tue, 10 May 2022 01:20:47 +0000 (18:20 -0700)
commit6e70c6f08a8b523da2f811e5d656fc75ae32235e
tree3adcdb3da7b925bf9302719273a5da230d80482a
parentd145b36612bbab1eab6eb7415b797211c11b1bdf
mm/gup: fix comments to pin_user_pages_*()

pin_user_pages API forces FOLL_PIN in gup_flags, which means that the API
requires struct page **pages to be provided (not NULL).  However, the
comment to pin_user_pages() clearly allows for passing in a NULL @pages
argument.

Remove the incorrect comments, and add WARN_ON_ONCE(!pages) calls to
enforce the API.

It has been independently spotted by Minchan Kim and confirmed with
John Hubbard:

https://lore.kernel.org/all/YgWA0ghrrzHONehH@google.com/

Link: https://lkml.kernel.org/r/20220422015839.1274328-1-yury.norov@gmail.com
Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
Cc: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/gup.c