]> git.baikalelectronics.ru Git - kernel.git/commit
staging/rts5208: fix incorrect shift to extract upper nybble
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Aug 2017 13:34:16 +0000 (14:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Aug 2017 18:08:41 +0000 (11:08 -0700)
commit6e52f64f1c4d49973fc783e8cb9b8dc01367a7dd
treec544b6700149cc5133e22f3c3a93c7f761d61d2a
parent8dd4ce7eb19eb4030227978ee90b3894c79bacc2
staging/rts5208: fix incorrect shift to extract upper nybble

The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0.  Fix this by shifting only by 4 bits to correctly get the upper nybble.

Detected by CoverityScan, CID#142891 ("Operands don't affect result")

Fixes: 73e911627d54 ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/rtsx_scsi.c