]> git.baikalelectronics.ru Git - kernel.git/commit
x86: Mark OPTIMIZE_INLINING broken
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 02:50:03 +0000 (19:50 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 1 May 2008 03:07:22 +0000 (20:07 -0700)
commit6e3295f03a5d1fce491611818b28e86a67fb8460
tree5aab64f86dc6697bba085884c28f32ea031a1e99
parent4e1b47e3ae60fb2bae6f3f4d23cac96ae856138b
x86: Mark OPTIMIZE_INLINING broken

So Ingo finally did figure out why UML broke with this option: UML
passes gcc the -fno-unit-at-a-time flag, and apparently that wreaks
havoc with gcc's inlining.

We could turn off -fno-unit-at-a-time for UML for gcc4+ (which is what
x86 does), but there's bad blood about this whole option, and it does
show that the thing is just fragile as heck.

So let tempers cool, and disable the thing, and we can revisit the
decision later.

Cc: Adrian Bunk <bunk@kernel.org>
Cc: David Miller <davem@davemloft.net>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
arch/x86/Kconfig.debug