]> git.baikalelectronics.ru Git - kernel.git/commit
V4L/DVB (11832): dibusb_mc: fix i2c to not corrupt eeprom in case of strange read...
authormatthieu castet <castet.matthieu@free.fr>
Wed, 20 May 2009 08:42:33 +0000 (05:42 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Tue, 16 Jun 2009 21:21:09 +0000 (18:21 -0300)
commit6dddc6b1dcde4086282876446f80fd2c7576d27b
tree20550dc21f1efefa556f7a046b31cb32b0ac2f21
parentb6391964ba3a1b89d8200d794b2c7726611a0271
V4L/DVB (11832): dibusb_mc: fix i2c to not corrupt eeprom in case of strange read pattern

dibusb_i2c_xfer seems to do things very dangerous :
it assumes that it get only write/read request or write request.

That means that read can be understood as write. For example a program
doing
file = open("/dev/i2c-x", O_RDWR);
    ioctl(file, I2C_SLAVE, 0x50)
read(file, data, 10)
    will corrupt the eeprom as it will be understood as a write.

Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/dvb-usb/dibusb-common.c