]> git.baikalelectronics.ru Git - kernel.git/commit
jfs: Fix early release of acl in jfs_get_acl
authorStefan Bader <stefan.bader@canonical.com>
Thu, 23 Jul 2009 09:26:05 +0000 (11:26 +0200)
committerDave Kleikamp <shaggy@linux.vnet.ibm.com>
Thu, 23 Jul 2009 16:08:36 +0000 (11:08 -0500)
commit6ddaabe3f5a39121fdb41ab6c528479a759c23c7
tree62ffffbec656eb462cd7ae6cc4a615400b5cb5b5
parent8cb0e08ea6a50db8f60386cef80c176481efb6c2
jfs: Fix early release of acl in jfs_get_acl

BugLink: http://bugs.launchpad.net/ubuntu/+bug/396780
Commit c2a12ad023311b50e0d55f4da8b9a67ddc22fb63 "helpers for acl
caching + switch to those" introduced new helper functions for
acl handling but seems to have introduced a regression for jfs as
the acl is released before returning it to the caller, instead of
leaving this for the caller to do.
This causes the acl object to be used after freeing it, leading
to kernel panics in completely different places.

Thanks to Christophe Dumez for reporting and bisecting into this.

Reported-by: Christophe Dumez <dchris@gmail.com>
Tested-by: Christophe Dumez <dchris@gmail.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
fs/jfs/acl.c