]> git.baikalelectronics.ru Git - kernel.git/commit
batman-adv: Fix transmission of final, 16th fragment
authorLinus Lüssing <linus.luessing@c0d3.blue>
Mon, 13 Feb 2017 19:44:31 +0000 (20:44 +0100)
committerSimon Wunderlich <sw@simonwunderlich.de>
Tue, 21 Feb 2017 17:33:35 +0000 (18:33 +0100)
commit6dd4e48ef240f7f860fdaa885745704a1988d029
tree296d85df700b380a2692fe3fa7b370dd0e915409
parent9e0b46b8af45370e1fb2b89648076a6d53456ce2
batman-adv: Fix transmission of final, 16th fragment

Trying to split and transmit a unicast packet in 16 parts will fail for
the final fragment: After having sent the 15th one with a frag_packet.no
index of 14, we will increase the the index to 15 - and return with an
error code immediately, even though one more fragment is due for
transmission and allowed.

Fixing this issue by moving the check before incrementing the index.

While at it, adding an unlikely(), because the check is actually more of
an assertion.

Fixes: f058d0a8b8cc ("batman-adv: Fragment and send skbs larger than mtu")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/fragmentation.c