]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove
authorJanusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Fri, 18 Oct 2019 10:07:10 +0000 (12:07 +0200)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 18 Oct 2019 21:42:59 +0000 (22:42 +0100)
commit6db2acb24bbe24046b5474c941d92821ec01a5b7
treefcbe25b772228dab6757aef1016808078369b1bd
parent9dd93b03649588bcda0d4d3271b86a5e5c54e6f8
drm/i915: Restore full symmetry in i915_driver_modeset_probe/remove

Commit 612722c3dd19 ("drm/i915: add i915_driver_modeset_remove()")
claimed removal of asymmetry in probe() and remove() calls, however, it
didn't take care of calling intel_irq_uninstall() on driver remove.
That doesn't hurt as long as we still call it from
intel_modeset_driver_remove() but in order to have full symmetry we
should call it again from i915_driver_modeset_remove().

Note that it's safe to call intel_irq_uninstall() twice thanks to
commit 92893a8bfadf ("drm/i915: Nuke drm_driver irq vfuncs").  We may
only want to mention the case we are adding in a related FIXME comment
provided by that commit.  While being at it, update the name of
function mentioned as calling it out of sequence as that name has been
changed meanwhile by commit b631bab3d52d ("drm/i915: Propagate
"_remove" function name suffix down").

Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/6250061.7lZMOAyebC@jkrzyszt-desk.ger.corp.intel.com
drivers/gpu/drm/i915/i915_drv.c
drivers/gpu/drm/i915/i915_irq.c