]> git.baikalelectronics.ru Git - kernel.git/commit
ovl: filter of trusted xattr results in audit
authorMark Salyzyn <salyzyn@android.com>
Thu, 29 Aug 2019 18:30:14 +0000 (11:30 -0700)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 11 Sep 2019 14:11:45 +0000 (16:11 +0200)
commit6da1fbc23e94c1ac1315b65b1ab3b03f99ce6fa0
tree2f2d9b40f4d7775482b5eb67173ddd6b382b5a3e
parent3cf37ca4fa1e44e45548e87154ef5ab9f95d18d3
ovl: filter of trusted xattr results in audit

When filtering xattr list for reading, presence of trusted xattr
results in a security audit log.  However, if there is other content
no errno will be set, and if there isn't, the errno will be -ENODATA
and not -EPERM as is usually associated with a lack of capability.
The check does not block the request to list the xattrs present.

Switch to ns_capable_noaudit to reflect a more appropriate check.

Signed-off-by: Mark Salyzyn <salyzyn@android.com>
Cc: linux-security-module@vger.kernel.org
Cc: kernel-team@android.com
Cc: stable@vger.kernel.org # v3.18+
Fixes: f83e5b6f8851 ("ovl: filter trusted xattr for non-admin")
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/inode.c