]> git.baikalelectronics.ru Git - kernel.git/commit
macsec: fix NULL deref in macsec_add_rxsa
authorSabrina Dubroca <sd@queasysnail.net>
Fri, 22 Jul 2022 09:16:27 +0000 (11:16 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 25 Jul 2022 10:49:25 +0000 (11:49 +0100)
commit6d3134025b04a9fad9dc521822288dd3307a50fa
tree1eaea45d134da6e97904997ca1a9f786f716cbb9
parentdd25e9e274ea2c11ac3dbf008f0fa1d6a613699d
macsec: fix NULL deref in macsec_add_rxsa

Commit f5e80c04da34 added a test on tb_sa[MACSEC_SA_ATTR_PN], but
nothing guarantees that it's not NULL at this point. The same code was
added to macsec_add_txsa, but there it's not a problem because
validate_add_txsa checks that the MACSEC_SA_ATTR_PN attribute is
present.

Note: it's not possible to reproduce with iproute, because iproute
doesn't allow creating an SA without specifying the PN.

Fixes: f5e80c04da34 ("macsec: Netlink support of XPN cipher suites (IEEE 802.1AEbw)")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=208315
Reported-by: Frantisek Sumsal <fsumsal@redhat.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macsec.c