]> git.baikalelectronics.ru Git - kernel.git/commit
net: fec: only clear interrupt of handling queue in fec_enet_rx_queue()
authorJoakim Zhang <qiangqing.zhang@nxp.com>
Mon, 6 Dec 2021 13:54:57 +0000 (21:54 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Dec 2021 05:39:39 +0000 (21:39 -0800)
commit6d25fbf163f4517c4c0325082661d8018f400fb0
tree0e5e8fa7953e580b8704922f1ef69548d2f96a26
parent8b1894d8f60a0932dc796b3470c4652c9215502e
net: fec: only clear interrupt of handling queue in fec_enet_rx_queue()

Background:
We have a customer is running a Profinet stack on the 8MM which receives and
responds PNIO packets every 4ms and PNIO-CM packets every 40ms. However, from
time to time the received PNIO-CM package is "stock" and is only handled when
receiving a new PNIO-CM or DCERPC-Ping packet (tcpdump shows the PNIO-CM and
the DCERPC-Ping packet at the same time but the PNIO-CM HW timestamp is from
the expected 40 ms and not the 2s delay of the DCERPC-Ping).

After debugging, we noticed PNIO, PNIO-CM and DCERPC-Ping packets would
be handled by different RX queues.

The root cause should be driver ack all queues' interrupt when handle a
specific queue in fec_enet_rx_queue(). The blamed patch is introduced to
receive as much packets as possible once to avoid interrupt flooding.
But it's unreasonable to clear other queues'interrupt when handling one
queue, this patch tries to fix it.

Fixes: 70c316a5ef51 (net: fec: clear receive interrupts before processing a packet)
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Reported-by: Nicolas Diaz <nicolas.diaz@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Link: https://lore.kernel.org/r/20211206135457.15946-1-qiangqing.zhang@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec.h
drivers/net/ethernet/freescale/fec_main.c