]> git.baikalelectronics.ru Git - kernel.git/commit
platform/x86: i2c-multi-instantiate: Fail the probe if no IRQ provided
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 11 Oct 2019 10:22:58 +0000 (13:22 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 14 Oct 2019 12:31:50 +0000 (15:31 +0300)
commit6d233e2cac6fba80502ebd596d8282aba1a02f11
tree5ba27b609b1fdfc37d26d78a6826426905214f8a
parent94845104a1a32cca5461b4435b2081b5a84a3515
platform/x86: i2c-multi-instantiate: Fail the probe if no IRQ provided

For APIC case of interrupt we don't fail a ->probe() of the driver,
which makes kernel to print a lot of warnings from the children.

We have two options here:
- switch to platform_get_irq_optional(), though it won't stop children
  to be probed and failed
- fail the ->probe() of i2c-multi-instantiate

Since the in reality we never had devices in the wild where IRQ resource
is optional, the latter solution suits the best.

Fixes: e551c9c27b83 ("platform/x86: i2c-multi-instantiate: Introduce IOAPIC IRQ support")
Reported-by: Ammy Yi <ammy.yi@intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
drivers/platform/x86/i2c-multi-instantiate.c