]> git.baikalelectronics.ru Git - kernel.git/commit
bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 21 Apr 2022 14:35:49 +0000 (16:35 +0200)
committerJernej Skrabec <jernej.skrabec@gmail.com>
Mon, 25 Apr 2022 17:29:04 +0000 (19:29 +0200)
commit6d1146c8432f59686de989031dba563ff3b60edf
tree5ac1a1425ad804c697d7d218d368120ff3f5073e
parentdbb008736a8c113ef1e12b4e4b4351fac2a15ede
bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()

This code is really spurious.
It always returns an ERR_PTR, even when err is known to be 0 and calls
put_device() after a successful device_register() call.

It is likely that the return statement in the normal path is missing.
Add 'return rdev;' to fix it.

Fixes: ef5ba27c1b01 ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Samuel Holland <samuel@sholland.org>
Tested-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/ef2b9576350bba4c8e05e669e9535e9e2a415763.1650551719.git.christophe.jaillet@wanadoo.fr
drivers/bus/sunxi-rsb.c