]> git.baikalelectronics.ru Git - kernel.git/commit
workqueue: clear POOL_DISASSOCIATED in rebind_workers()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 3 Jun 2014 07:33:27 +0000 (15:33 +0800)
committerTejun Heo <tj@kernel.org>
Thu, 19 Jun 2014 19:43:33 +0000 (15:43 -0400)
commit6cce0a26d86e77422c3583572647e440f4602a58
tree46e5a4baeb2fb82ceacfe3e8db263be12b1819ec
parent44e51e9a3ba198834adad98d87358c1112bdbf51
workqueue: clear POOL_DISASSOCIATED in rebind_workers()

The commit 8795de177901 ("workqueue: directly restore CPU affinity of
workers from CPU_ONLINE") moved the pool->lock into rebind_workers()
without also moving "pool->flags &= ~POOL_DISASSOCIATED".

There is nothing wrong with "pool->flags &= ~POOL_DISASSOCIATED" not
being moved together, but there isn't any benefit either. We move it
into rebind_workers() and achieve these benefits:

1) Better readability.  POOL_DISASSOCIATED is cleared in
   rebind_workers() as expected.

2) When POOL_DISASSOCIATED is cleared, we can ensure that all the
   running workers of the pool are on the local CPU (pool->cpu).

tj: Cosmetic updates to the code and description.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c