]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: imx: fix reference leak when pm_runtime_get_sync fails
authorQinglang Miao <miaoqinglang@huawei.com>
Tue, 1 Dec 2020 09:31:41 +0000 (17:31 +0800)
committerWolfram Sang <wsa@kernel.org>
Wed, 14 Apr 2021 07:49:13 +0000 (09:49 +0200)
commit6cba81acc95880ea303b254d2eb5ee9059c9c3b1
treed9568d17133dae71c253626c5e67ac49f27f49e9
parentf3ab52d620750c9c79eb0efd04b040ec13b0372d
i2c: imx: fix reference leak when pm_runtime_get_sync fails

In i2c_imx_xfer() and i2c_imx_remove(), the pm reference count
is not expected to be incremented on return.

However, pm_runtime_get_sync will increment pm reference count
even failed. Forgetting to putting operation will result in a
reference leak here.

Replace it with pm_runtime_resume_and_get to keep usage
counter balanced.

Fixes: 2851c0fcdb8e ("i2c: imx: implement master_xfer_atomic callback")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-imx.c