]> git.baikalelectronics.ru Git - kernel.git/commit
clk: remove unneeded dead-store initialization
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Fri, 6 Nov 2020 09:48:20 +0000 (10:48 +0100)
committerStephen Boyd <sboyd@kernel.org>
Sat, 14 Nov 2020 20:32:29 +0000 (12:32 -0800)
commit6c66a673a40f4fcdbf58d38e8932fdb5cd742dba
treef2e312687357ed4c9362c23bc2d582e6af9c8074
parenta1fe7c755400af92f0070a66f48f00b659aeacac
clk: remove unneeded dead-store initialization

make clang-analyzer on x86_64 defconfig caught my attention with:

  drivers/clk/clk.c:423:19:
  warning: Value stored to 'parent' during its initialization is never read
  [clang-analyzer-deadcode.DeadStores]
          struct clk_core *parent = ERR_PTR(-ENOENT);
                           ^

Commit f8441069c1d5 ("clk: Allow parents to be specified without string
names") introduced clk_core_fill_parent_index() with this unneeded
dead-store initialization.

So, simply remove this unneeded dead-store initialization to make
clang-analyzer happy.

As compilers will detect this unneeded assignment and optimize this anyway,
the resulting object code is identical before and after this change.

No functional change. No change to object code.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Link: https://lore.kernel.org/r/20201106094820.30167-1-lukas.bulwahn@gmail.com
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c