]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: core: sysfs: Remove comments that conflict with the actual logic
authorJackie Liu <liuyun01@kylinos.cn>
Tue, 29 Mar 2022 02:12:51 +0000 (10:12 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 30 Mar 2022 03:54:26 +0000 (23:54 -0400)
commit6c555c4931402477fe50b8e297737ce76d671031
treefa14979c07e8f4feb591cc0f3d4ae40b06ad002c
parent9ec694579f44c502cddbe8f91620b70c79d8b527
scsi: core: sysfs: Remove comments that conflict with the actual logic

Christoph Hellwig Says:
=======================
I think we should just handle the error properly and remove the comment.
There's no good reason to ignore bsg registration errors.

In fact, after commit 8fc60c9df055 ("scsi: core: Register sysfs attributes
earlier"), we are already forced to return errno.

We discuss this issue in [1].

[1] https://lore.kernel.org/all/20211022010201.426746-1-liu.yun@linux.dev/

Link: https://lore.kernel.org/r/20220329021251.123805-1-liu.yun@linux.dev
Suggested-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_sysfs.c