]> git.baikalelectronics.ru Git - kernel.git/commit
projects / kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3a73d34) | patch
macb: Remove inappropriate spinlocks around mii calls
authorHaavard Skinnemoen <hskinnemoen@atmel.com>
Fri, 16 Feb 2007 14:59:06 +0000 (15:59 +0100)
committerJeff Garzik <jeff@garzik.org>
Sat, 17 Feb 2007 20:30:48 +0000 (15:30 -0500)
commit6c2f6698c1d1d41f6505b091dc149f23e08f947e
tree4481f795dffd8db8fe1723200614018d06ac2815tree | snapshot
parent3a73d34a6c4218214ca00e2f7590698086db94ddcommit | diff
macb: Remove inappropriate spinlocks around mii calls

Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset
and generic_mii_ioctl. These are unnecessary and harmful because
the mii calls may call back into the mdio functions, which may sleep.

Pointed out by David Brownell.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/macb.c diff | blob | history
Linux Kernel Source Tree.