]> git.baikalelectronics.ru Git - kernel.git/commit
soc: qcom: aoss: remove spurious IRQF_ONESHOT flags
authorDaniel Thompson <daniel.thompson@linaro.org>
Thu, 27 Jan 2022 17:35:54 +0000 (17:35 +0000)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 1 Feb 2022 00:12:20 +0000 (18:12 -0600)
commit6bfea887754a4722de9ce2668530c321e8dccce7
treefb6bd6fe20c80f931af12fb397ca5dccd3ab2c3e
parent7f78db1e39a665cc3b87743b52aed3bd7c7d1012
soc: qcom: aoss: remove spurious IRQF_ONESHOT flags

Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts
which need to keep the irq line disabled until the threaded handler has
been run.". When applied to an interrupt that doesn't request a threaded
irq then IRQF_ONESHOT has a lesser known (undocumented?) side effect,
which it to disable the forced threading of the irq. For "normal" kernels
(without forced threading) then, if there is no thread_fn, then
IRQF_ONESHOT is a nop.

In this case disabling forced threading is not appropriate for this driver
because it calls wake_up_all() and this API cannot be called from
no-thread interrupt handlers on PREEMPT_RT systems (deadlock risk, triggers
sleeping-while-atomic warnings).

Fix this by removing IRQF_ONESHOT.

Fixes: 4ec131d083ff ("soc: qcom: Add AOSS QMP driver")
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
[bjorn: Added Fixes tag]
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220127173554.158111-1-daniel.thompson@linaro.org
drivers/soc/qcom/qcom_aoss.c