]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/platform/x86: Adjust confusing if indentation
authorJulia Lawall <julia@diku.dk>
Thu, 5 Aug 2010 20:24:12 +0000 (22:24 +0200)
committerMatthew Garrett <mjg@redhat.com>
Mon, 16 Aug 2010 15:54:20 +0000 (11:54 -0400)
commit6bfa3cd76fd5e0588a3c891b0fb2a05605b682ac
tree38dbfed5f655aa1ea3bd5aa23abb760f998cd7ae
parentb35f239270a02aa3dec19df6d70cdfbc2dafca0f
drivers/platform/x86: Adjust confusing if indentation

The assignment of ret to -EIO appears to only make sense if the branch that
it is aligned with is executed, so move it into that branch.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable braces4@
position p1,p2;
statement S1,S2;
@@

(
if (...) { ... }
|
if (...) S1@p1 S2@p2
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

if (p1[0].column == p2[0].column):
  cocci.print_main("branch",p1)
  cocci.print_secs("after",p2)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/asus_acpi.c