]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: pciehp: Wait for PDS if in-band presence is disabled
authorAlexandru Gagniuc <mr.nuke.me@gmail.com>
Fri, 25 Oct 2019 19:00:46 +0000 (15:00 -0400)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 21 Feb 2020 04:47:29 +0000 (22:47 -0600)
commit6bc80484fe58400a5a2ffc1ca685f952a88304b8
treec606dad182118087302634f9315e84d88b2ff956
parenta6bd1110d609894207fc9c46893014f0cfb31493
PCI: pciehp: Wait for PDS if in-band presence is disabled

When in-band presence detect is disabled, PDS may come up at any time or
not at all.  PDS being low may indicate that the card is still mating, and
we could expect contact bounce to bring down the link as well.

It is reasonable to assume that most cards will mate in a hotplug slot in
about a second.  Thus, when we know PDS only reflects out-of-band presence
detect, it's worthwhile to wait the extra second or so to make sure the
card is properly mated before loading the driver and to prevent the hotplug
code from disabling a device if the presence detect change goes active
after the device is enabled.

Link: https://lore.kernel.org/r/20191025190047.38130-3-stuart.w.hayes@gmail.com
[bhelgaas: use ctrl_info() instead of pci_info()]
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
drivers/pci/hotplug/pciehp_hpc.c