]> git.baikalelectronics.ru Git - kernel.git/commit
module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols
authorFangrui Song <maskray@google.com>
Fri, 15 Jan 2021 19:52:22 +0000 (11:52 -0800)
committerJessica Yu <jeyu@kernel.org>
Mon, 18 Jan 2021 09:45:42 +0000 (10:45 +0100)
commit6b684c5ef3f92647238fe4d5a60eb6cb9f174254
treee23b14bde63d8aca06ee810118435c2aa1da272a
parent0649f8af0eb66e6f7fc7bd022b3199d7254272f1
module: Ignore _GLOBAL_OFFSET_TABLE_ when warning for undefined symbols

clang-12 -fno-pic (since
https://github.com/llvm/llvm-project/commit/a084c0388e2a59b9556f2de0083333232da3f1d6)
can emit `call __stack_chk_fail@PLT` instead of `call __stack_chk_fail`
on x86.  The two forms should have identical behaviors on x86-64 but the
former causes GNU as<2.37 to produce an unreferenced undefined symbol
_GLOBAL_OFFSET_TABLE_.

(On x86-32, there is an R_386_PC32 vs R_386_PLT32 difference but the
linker behavior is identical as far as Linux kernel is concerned.)

Simply ignore _GLOBAL_OFFSET_TABLE_ for now, like what
scripts/mod/modpost.c:ignore_undef_symbol does. This also fixes the
problem for gcc/clang -fpie and -fpic, which may emit `call foo@PLT` for
external function calls on x86.

Note: ld -z defs and dynamic loaders do not error for unreferenced
undefined symbols so the module loader is reading too much.  If we ever
need to ignore more symbols, the code should be refactored to ignore
unreferenced symbols.

Cc: <stable@vger.kernel.org>
Link: https://github.com/ClangBuiltLinux/linux/issues/1250
Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27178
Reported-by: Marco Elver <elver@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Tested-by: Marco Elver <elver@google.com>
Signed-off-by: Fangrui Song <maskray@google.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
kernel/module.c