]> git.baikalelectronics.ru Git - kernel.git/commit
ibmvnic: notify peers when failover and migration happen
authorLijun Pan <ljp@linux.ibm.com>
Fri, 20 Nov 2020 22:40:12 +0000 (16:40 -0600)
committerJakub Kicinski <kuba@kernel.org>
Sat, 21 Nov 2020 23:30:47 +0000 (15:30 -0800)
commit6b42987ebca4a871245c05709866ce4333fb3a7a
tree218a36a56aa5ad16571b741b8679a8e512c0db4a
parentfd1e4f93bb63ccdfef8a548c4b74b6a2da8b655b
ibmvnic: notify peers when failover and migration happen

Commit 0b4a84f5f01f ("ibmvnic: Remove netdev notify for failover resets")
excluded the failover case for notify call because it said
netdev_notify_peers() can cause network traffic to stall or halt.
Current testing does not show network traffic stall
or halt because of the notify call for failover event.
netdev_notify_peers may be used when a device wants to inform the
rest of the network about some sort of a reconfiguration
such as failover or migration.

It is unnecessary to call that in other events like
FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets
since in those scenarios the hardware does not change.
If the driver must do a hard reset, it is necessary to notify peers.

Fixes: 0b4a84f5f01f ("ibmvnic: Remove netdev notify for failover resets")
Suggested-by: Brian King <brking@linux.vnet.ibm.com>
Suggested-by: Pradeep Satyanarayana <pradeeps@linux.vnet.ibm.com>
Signed-off-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c