]> git.baikalelectronics.ru Git - kernel.git/commit
PCI: sysfs: Revert "rescan" file renames
authorKelsey Skunberg <kelsey.skunberg@gmail.com>
Wed, 25 Mar 2020 15:17:08 +0000 (09:17 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 30 Mar 2020 15:01:48 +0000 (10:01 -0500)
commit6b278eae5f1d3bf9c1145394da24536485f6a60c
tree84804a5dcc3282d79811da6498c85362f4ac3992
parent41235c099bea222b627e1a0d96eaf659f8e8a9e4
PCI: sysfs: Revert "rescan" file renames

We changed these sysfs filenames:

  .../pci_bus/<domain:bus>/rescan  ->  .../pci_bus/<domain:bus>/bus_rescan
  .../<domain:bus:dev.fn>/rescan   ->  .../<domain:bus:dev.fn>/dev_rescan

and Ruslan reported [1] that this broke a userspace application.

Revert these name changes so both files are named "rescan" again.

Note that we have to use __ATTR() to assign custom C symbols, i.e.,
"struct device_attribute <symbol>".

[1] https://lore.kernel.org/r/CAB=otbSYozS-ZfxB0nCiNnxcbqxwrHOSYxJJtDKa63KzXbXgpw@mail.gmail.com

[bhelgaas: commit log, use __ATTR() both places so we don't have to rename
the attributes]
Fixes: b4231d17e2d0 ("PCI: sysfs: Define device attributes with DEVICE_ATTR*()")
Fixes: 02f77cc5150c ("PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO()")
Link: https://lore.kernel.org/r/20200325151708.32612-1-skunberg.kelsey@gmail.com
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org # v5.4+
drivers/pci/pci-sysfs.c