]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: libsas: fix length error in sas_smp_handler()
authorJason Yan <yanaijie@huawei.com>
Mon, 11 Dec 2017 07:03:33 +0000 (15:03 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 12 Dec 2017 02:45:34 +0000 (21:45 -0500)
commit6ab00156027ee30d23ffd8efe00ed02dcae998db
treee15d20dd76d616136e55352e311f7f5bbb549363
parentdcaa1ff7b88ab880e602bb12d85660b18d177e2e
scsi: libsas: fix length error in sas_smp_handler()

The return value of smp_execute_task_sg() is the untransferred residual,
but bsg_job_done() requires the length of payload received. This makes
SMP passthrough commands from userland by sg ioctl to libsas get a wrong
response. The userland tools such as smp_utils failed because of these
wrong responses:

~#smp_discover /dev/bsg/expander-2\:13
response too short, len=0
~#smp_discover /dev/bsg/expander-2\:134
response too short, len=0

Fix this by passing the actual received length to bsg_job_done(). And if
smp_execute_task_sg() returns 0, this means received length is exactly
the buffer length.

[mkp: typo]

Fixes: f3cf1b94b008 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough")
Cc: <stable@vger.kernel.org> # v4.14+
Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reported-by: chenqilin <chenqilin2@huawei.com>
Tested-by: chenqilin <chenqilin2@huawei.com>
CC: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_expander.c