]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: ti: cpsw: remove rx_descs property
authorIvan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Fri, 17 Jun 2016 10:25:39 +0000 (13:25 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 18 Jun 2016 04:27:57 +0000 (21:27 -0700)
commit6a4346df947f77295fb2d15165a80bdaf31d680d
tree88647e5114ccf28c90709879635e332d22e571fe
parent281fec8413b5b4b3eece766eef2dd55de614bbe2
net: ethernet: ti: cpsw: remove rx_descs property

There is no reason in rx_descs property because davinici_cpdma
driver splits pool of descriptors equally between tx and rx channels.
That is, if number of descriptors 256, 128 of them are for rx
channels. While receiving, the descriptor is freed to the pool and
then allocated with new skb. And if in DT the "rx_descs" is set to
64, then 128 - 64 = 64 descriptors are always in the pool and cannot
be used, for tx, for instance. It's not correct resource usage,
better to set it to half of pool, then the rx pool can be used in
full. It will not have any impact on performance, as anyway, the
"redundant" descriptors were unused.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c
drivers/net/ethernet/ti/cpsw.h
drivers/net/ethernet/ti/davinci_cpdma.c
drivers/net/ethernet/ti/davinci_cpdma.h