]> git.baikalelectronics.ru Git - kernel.git/commit
lightnvm: Fix uninitialized return value in nvm_get_chunk_meta()
authorGeert Uytterhoeven <geert@linux-m68k.org>
Tue, 11 Dec 2018 19:16:08 +0000 (20:16 +0100)
committerJens Axboe <axboe@kernel.dk>
Tue, 11 Dec 2018 19:22:33 +0000 (12:22 -0700)
commit6a3fd844e30ebcea2e7ddf167475ae8f33f219f0
tree2a7b324655ff1fe53a9cbbca911fd2fd0b9887b9
parentbdea7c69355b6e9f3b4b490926ac24669e64cffa
lightnvm: Fix uninitialized return value in nvm_get_chunk_meta()

With gcc 4.1:

    drivers/lightnvm/core.c: In function ‘nvm_get_bb_meta’:
    drivers/lightnvm/core.c:977: warning: ‘ret’ may be used uninitialized in this function

and

    drivers/nvme/host/lightnvm.c: In function ‘nvme_nvm_get_chk_meta’:
    drivers/nvme/host/lightnvm.c:580: warning: ‘ret’ may be used uninitialized in this function

Indeed, if (for the former) the number of channels or LUNs is zero, or
(for both) the passed number of chunks is zero, ret will be returned
uninitialized.

Fix this by preinitializing ret to zero.

Fixes: a868156b9a141f9e ("lightnvm: move bad block and chunk state logic to core")
Fixes: d96a869661f15ade ("lightnvm: implement get log report chunk helpers")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/lightnvm/core.c
drivers/nvme/host/lightnvm.c